Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x.com for tweets #527

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Support x.com for tweets #527

merged 2 commits into from
Sep 10, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Sep 10, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #527 (1ad0a22) into master (438b0c7) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   47.13%   47.19%   +0.05%     
==========================================
  Files          99       99              
  Lines        3717     3721       +4     
==========================================
+ Hits         1752     1756       +4     
  Misses       1914     1914              
  Partials       51       51              
Files Changed Coverage Δ
internal/resolvers/twitter/resolver.go 100.00% <100.00%> (ø)
pkg/utils/url.go 18.46% <100.00%> (+5.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada
Copy link
Member Author

pajlada commented Sep 10, 2023

Confirmed locally that it works
image

@pajlada pajlada merged commit c2f3c3b into master Sep 10, 2023
10 checks passed
@pajlada pajlada deleted the feat/support-x-for-tweets branch September 10, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant